Added tls certs and keys settings

[capgadsx]

This changes will allow us to use ldaps:// endpoints.

Closes #49

[capgadsx]

Wrong repo! :upside_down_face:, feel free to delete.

[dhirschfeld]

Where did you mean to open this PR??

It seems this might solve #49?

[capgadsx]

Yes, it should, i was in a similar situation that OP of #49 is (our LDAP server uses self signed certificates and client keys/certs). However i should add some validation to the inputs before this is merged.

PS: Initially i was trying to merge this in the master branch of my fork but i pressed the wrong button (lol).

[dhirschfeld]

Thanks for posting @capgadsx! I'm currently slammed at work so it'll likely be a week or so before I get around to properly reviewing. I am keen to get it in though if it resolves #49.

[rayburgemeestre]

Hey it would have been really nice if you guys merged this back in 2018 :) I just patched this file in a similar way for our ldaps.

Any chance this PR might be reconsidered/updated for merge?

[consideRatio]

This PR seem to solve a relevant issue for users! Thanks for your work on this @capgadsx and others commenting in to verify the case!

I'm not knowledgeable enough to review this =/

[dmpe]

My company is going to force LDAPs as well and this would be great to have in master ;). I vouch to help if necessary

[capgadsx]

Hi, I see that the PR has attracted more interest, so I want to make some changes and write the integration tests that @manics mentions. I'll pick this up when I have some free time.

[serverwentdown]

@capgadsx I might take a look at writing integration tests.

[meeseeksmachine]

This pull request has been mentioned on Jupyter Community Forum. There might be relevant details there:

https://discourse.jupyter.org/t/jupyterhub-ldap-auth-using-certificate-how-to/13604/4