ldapauthenticator icon indicating copy to clipboard operation
ldapauthenticator copied to clipboard

Add admin_groups to grant admin access to users of these groups

Open Vendetta01 opened this issue 4 years ago • 4 comments

This PR adds a new configuration option admin_groups, to grant admin access to all users that are members of these groups and thus lets you define admin access through ldap group membership. Its implementation is similar to allowed_groups.

This fixes #160.

Vendetta01 avatar Jun 12 '21 19:06 Vendetta01

Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly. welcome You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

welcome[bot] avatar Jun 12 '21 19:06 welcome[bot]

When this PR will be merged?

firemdkfighter avatar Aug 03 '21 06:08 firemdkfighter

:+1: for getting this merged! Thanks for the contribution

Yayg avatar Sep 24 '21 09:09 Yayg

plus for this PR. When it will be merged?

mrdrelar avatar Jan 19 '22 10:01 mrdrelar