jupyterhub-idle-culler icon indicating copy to clipboard operation
jupyterhub-idle-culler copied to clipboard

Switch to aiohttp for requests in jupyterhub's cull_idle_servers

Open minrk opened this issue 6 years ago • 14 comments

JupyterHub uses tornado's httpclient to make requests internally. We would like to switch to using aiohttp instead.

Tasks:

  1. read cull_idle_servers.py
  2. install jupyterhub, aiohttp
  3. learn how to make requests with aiohttp
  4. find uses of AsyncHTTPClient in the script
  5. replace them with uses of aiohttp
  6. open a pull request to jupyterhub/jupyterhub with the changes

Remember, you don't need to already know how to do all this! We'll help you. Respond to the issue here if you have questions :)

minrk avatar Sep 20 '18 12:09 minrk

Hi! My name is Sasha, I'm an Outreachy applicant, and I would like to work on this task.

religofsil avatar Sep 21 '18 12:09 religofsil

@religofsil great! Feel free to ask further questions here or on gitter. The place to start is getting set up with a local install of jupyterhub.

minrk avatar Sep 21 '18 13:09 minrk

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively. welcome You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

welcome[bot] avatar Oct 13 '22 13:10 welcome[bot]

@religofsil have you made any progress on this? Feel free to stop by gitter or ask questions here if you have them. If we don't hear from you in a couple of days, we will reopen this issue so other applicants can look at it.

minrk avatar Oct 04 '18 15:10 minrk

Hey @minrk @religofsil . If no one is taking up the issue, I would like to work on this.

kshitija08 avatar Oct 05 '18 14:10 kshitija08

@minrk sorry, I was just reading the documentation on aiohttp and on asynchronous python, and got a bit lost, but I'm working on it!

religofsil avatar Oct 05 '18 14:10 religofsil

@religofsil no problem, just checking in! Feel free to ask questions here or in Gitter.

minrk avatar Oct 08 '18 07:10 minrk

@religofsil are you still working on this one? If not, I'd like to make it available to other applicants. If so, that's fine, too! Feel free to ask questions if you need help.

minrk avatar Oct 23 '18 08:10 minrk

Yes, I am! Sorry it's taking so long. :(

religofsil avatar Oct 24 '18 23:10 religofsil

No worries! Please feel free to ask questions here or on Gitter if you get stuck.

minrk avatar Oct 25 '18 09:10 minrk

@religofsil Hey, I would like to help in this issue. Kindly, let me know if I could work on this

kshitija08 avatar Nov 06 '18 07:11 kshitija08

While the description is outdated @minrk, the issue seems relevant still. Right?

See https://github.com/jupyterhub/jupyterhub-idle-culler/blob/main/jupyterhub_idle_culler/init.py

consideRatio avatar Oct 10 '22 09:10 consideRatio

@consideRatio that's true!

minrk avatar Oct 11 '22 13:10 minrk

@minrk and @consideRatio, I've moved the issue in this repository to not create confusion around the this year's Outreachy projects. Plus, I believe it has more visibility here.

GeorgianaElena avatar Oct 13 '22 13:10 GeorgianaElena