jupyterhub-deploy-docker
jupyterhub-deploy-docker copied to clipboard
Support http-configurable and nginx reverse proxy
Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct.
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:
Thanks for the PR! I think it'd be good to keep the basic example as simple as possible, but this would make a nice second example. Would you mind adding a new directory (you can probably just copy all the files from basic-example into that new directory), and add the directory to the test matrix? https://github.com/jupyterhub/jupyterhub-deploy-docker/blob/e31f3a5c9e12cb2d3e9fd30d9ec484ddf53c0c31/.github/workflows/test.yml#L31-L34