jupyterhub-deploy-docker icon indicating copy to clipboard operation
jupyterhub-deploy-docker copied to clipboard

let's encrypt fix

Open priamai opened this issue 2 years ago • 1 comments

The script uses an old syntax, it should be updated with this:

# Generate the cert and save it to the Docker volume
docker run --rm -it \
  -p 80:80 \
  -v $SECRETS_VOLUME:/etc/letsencrypt \
  quay.io/letsencrypt/letsencrypt:latest \
  certonly \
  --non-interactive \
  --keep-until-expiring \
  --standalone \
  --preferred-challenges http-01 \
  --agree-tos \
  --force-renewal \
  --domain "$FQDN" \
  --email "$EMAIL" \
  $CERT_SERVER

priamai avatar Feb 14 '22 18:02 priamai

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively. welcome You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

welcome[bot] avatar Feb 14 '22 18:02 welcome[bot]

Let-encrypt was removed to simplify maintenance

manics avatar Dec 05 '22 00:12 manics