jupyter-server-proxy icon indicating copy to clipboard operation
jupyter-server-proxy copied to clipboard

Adding a complete example to clarify where to put the config files.

Open dragz opened this issue 1 year ago • 4 comments

A small addition to the examples. I wasted a few hours trying to figure out where to put the config files. It might save some time for others.

dragz avatar Jun 26 '24 07:06 dragz

Thanks, I think having a full example makes sense. What do you think about linking to our test config instead: https://github.com/jupyterhub/jupyter-server-proxy/blob/main/tests/resources/jupyter_server_config.py

The advantage of that is it's always tested so will never go out of date, and also includes full examples for all config options.

manics avatar Jun 28 '24 14:06 manics

That makes perfect sense. I can change my PR or if you want to do it yourself you can just ignore my PR. What do you prefer?

dragz avatar Jul 02 '24 08:07 dragz

I tried copying the mentioned jupyter_server_config.py but it does not work out of the box. First it fails to launch the singleuserserver because it cannot find proxyextension. Commenting those two lines out make the server start but all test examples that shows up gives 500 internal error. All this will confuse a user trying to set this up.

dragz avatar Jul 09 '24 09:07 dragz

That's a fair point! Can you change your example so that it'll work on all systems? At the moment it'll only work with anaconda. For example, import and use sys.executable

manics avatar Jul 20 '24 12:07 manics