configurable-http-proxy icon indicating copy to clipboard operation
configurable-http-proxy copied to clipboard

Published 20 hours ago • verified publisher icon jupyterhub

[wip] ensure optionally-decoded characters (@, ~) are treated the same as their encoded counterparts

Open minrk opened this issue 7 years ago • 3 comments

we already had it working one direction (%40->@), but not the other (@->%40)

related to jupyterhub/jupyterhub#1717 but not actually necessary for the fix

minrk avatar May 25 '18 14:05 minrk

marking WIP since there seems to be something wonky

minrk avatar May 25 '18 15:05 minrk

Is there something blocking this? I have an issue with %40 in usernames (/user/myname@mydomain/ vs /user/myname%40mydomain/) returning 404s, which I think this PR would fix.

While my issue is with using code-server behind the jupyter-server-proxy, it is functionally identical to the problem discussed in jupyterhub/jupyterhub#2547.

Pugio avatar Oct 20 '20 01:10 Pugio

Please see the discussion on https://github.com/jupyterhub/jupyterhub/pull/3167. This is tricky to get right.

manics avatar Oct 20 '20 06:10 manics