reactivepy icon indicating copy to clipboard operation
reactivepy copied to clipboard

Refactor for future developers

Open willingc opened this issue 7 years ago • 3 comments

To make it easier for future developers on reactivepy, let's refactor a few things:

  • [x] Be consistent with f-strings since this supports 3.6+
  • [x] Clean up import statements (order by stdlib, 3rd party packages, reactivepy imports)
  • [ ] Add metadata for pypi to setup.py (pypa has an example repo and jupyterhub is a good model)
  • [ ] Go through and add docstrings that would be helpful for a future developer (they are also very handy for autodocumenting things) - Your 6 month from now self will thank you ;-)

willingc avatar Aug 31 '18 16:08 willingc

f-string stuff fixed by #24 #23 #22

declanvk avatar Sep 01 '18 00:09 declanvk

libraries fixed by #21

richagadgil avatar Sep 01 '18 00:09 richagadgil

Thanks @willingc !

ellisonbg avatar Sep 07 '18 00:09 ellisonbg