notebook icon indicating copy to clipboard operation
notebook copied to clipboard

UI issue in the "tree view" #7216

Open itsmevichu opened this issue 1 year ago • 1 comments

Issue No. #7216

Problem

The problem arises whenever these keywords, namely {“notebooks”, “edit”, ”consoles”, ”terminals”}, are detected in the path. This leads to undesired behaviour when directories with these keywords are present.

Some of our plugins actively monitor the URL path for the above keywords to execute corresponding commands. When these plugins come across the path with matching keywords(directories) during file browsing(tree view), they are forced to execute the associated command, which causes the issue.

Solution

  1. Since our file browsing consistently include the "tree" keyword in the path, I've explicitly handled the situation by ensuring that the plugins do not execute when the path contains the keyword "tree".
  2. In another scenario, when the folder structure is like /terminals/temp.ipynb, opening it redirects the path to /notebooks/terminals/temp.ipynb(also applies for other file formats); this unintentionally triggers the terminal-extension plugin. I alse have addressed this specific case explicitly to prevent such occurrences (This also applies to consoles).

Thank you for considering my contribution. And I welcome any feedback or suggestions for further improvements.

itsmevichu avatar Feb 10 '24 21:02 itsmevichu

Binder :point_left: Launch a Binder on branch itsmevichu/notebook/ingore-tree-patterns

github-actions[bot] avatar Feb 10 '24 21:02 github-actions[bot]