notebook icon indicating copy to clipboard operation
notebook copied to clipboard

Output cells no longer collapse completely

Open aodhanlutetiae opened this issue 10 months ago • 13 comments

Description

Version 7.0 doesn't allow user to collapse an output cell completely with a double click. This worked in 6.5.4. It is no longer possible in 7.0 (with either Firefox or Chrome).

Output is output

Single click still collapse to window single

Double click no longer collapses completely double

Setup Mac Ventura 13.5.1 Firefox 116.0.3, Chrome 116.0.5845.110 Jupyter 7.0, Jupyter 6.5.4

aodhanlutetiae avatar Aug 25 '23 10:08 aodhanlutetiae

Thanks @aodhanlutetiae for opening the issue.

Notebook 7 allows collapsing output cells by clicking on the collapser on the left:

image

https://github.com/jupyter/notebook/assets/591645/33b8464b-fffa-4393-826a-bc2147ac7099

Would you be able to give it a try to see if that also works with your setup?

jtpio avatar Aug 28 '23 05:08 jtpio

Thanks @jtpio. I now see that the functionality is there (see image) insofar as it works via the menu (View / Collapse selected outputs) but clicking on the collapser does nothing in my setup (Mac Ventura 13.5.1, notebook 7.0.2, Firefox 117.0).

collapse

aodhanlutetiae avatar Aug 29 '23 15:08 aodhanlutetiae

Would you be able to check if it is also an issue in JupyterLab?

If so we could move the issue there since Notebook 7 uses the JupyterLab notebook component.

jtpio avatar Aug 29 '23 16:08 jtpio

Just checked - it's not a problem in JupyterLab. The output cell collapses with a single click on the vertical blue bar.

aodhanlutetiae avatar Aug 30 '23 10:08 aodhanlutetiae

Hmm that's strange, because Notebook 7 does not do anything special to the collapsers.

I'm starting a new release which would include the update to the JupyterLab 4.0.5 packages. Maybe that would fix the issue, although there doesn't seem to be any related changes in the release notes: https://github.com/jupyterlab/jupyterlab/releases/tag/v4.0.5

jtpio avatar Aug 30 '23 14:08 jtpio

@aodhanlutetiae would you be able to try with 7.0.3? https://github.com/jupyter/notebook/releases/tag/v7.0.3

jtpio avatar Aug 30 '23 14:08 jtpio

FWIW, on 7.0.3 I can only hide the code/output of the very first cell in the notebook (i.e. it works at least partially). For any other cell in the notebook (both code and output) this does not work for me.

ruan-takealot avatar Aug 30 '23 15:08 ruan-takealot

Indeed, this does not seem to be an issue with JupyterLab:

https://github.com/jupyter/notebook/assets/591645/62480255-8a2b-44a3-ad1b-016328f6e095

jtpio avatar Aug 30 '23 17:08 jtpio

No change with Jupyter Notebook 7.0.3. As noted above, the blue bar will collapse input cell and output cell if it's the first cell in the notebook, but not after that.

aodhanlutetiae avatar Aug 30 '23 20:08 aodhanlutetiae

Could you please consider assigning this issue to me? I am enthusiastic about getting involved in the project and am eager to collaborate with your team to help address this matter.

parasiitism avatar Oct 26 '23 15:10 parasiitism

@jtpio I am trying to fix this on my local notebook setup, could you please help with the module that handles this functionality, or is there any doc which i could refer understand where is this implemented?

jayeshsingh9767 avatar Oct 28 '23 07:10 jayeshsingh9767

@jtpio I am trying to fix this on my local notebook setup, could you please help with the module that handles this functionality, or is there any doc which i could refer understand where is this implemented?

Well not sure there is anything specific in Notebook 7 w.r.t the cell collapsers. Most of the code is in JupyterLab and Notebook simply reuses the extension. Unless some of the extensions specific to Notebook 7 conflict with it in some way.

jtpio avatar Nov 22 '23 16:11 jtpio