notebook Update `@playwright/test`

Update `@playwright/test`

Open jtpio opened this issue 1 year ago • 2 comments

Updating @playwright/test to a newer version.

Sep 02 '22 13:09 jtpio

:point_left: Launch a Binder on branch jtpio/notebook/update-playwright

The global config in playwright.config.ts does not seem to be taken into account anymore:

https://github.com/jupyter/notebook/blob/b9dcb33ba516bbadd8395367ab45e8bb0fd49767/ui-tests/playwright.config.ts#L6-L8

Which means it's redirecting to /lab/tree instead. Overriding with test.use() locally in the test file works though.

Sep 02 '22 14:09 jtpio

Putting this one on hold for now.

A fix was submitted and merged upstream in https://github.com/jupyterlab/jupyterlab/pull/13140.

Waiting for https://github.com/jupyter/notebook/pull/6539 to get in first.

Sep 28 '22 17:09 jtpio