notebook icon indicating copy to clipboard operation
notebook copied to clipboard

get bower dependencies from npm

Open minrk opened this issue 4 years ago • 3 comments
trafficstars

Avoids dependency on deprecated bower package manager.

This is the same strategy adopted some time ago by JupyterHub, which also used Bower. Rather than making significant changes to how everything is built, which caused problems during the webpack, this only changes how the dependencies are downloaded. A bower-lite script copies dependencies declared in package.json from node_modules to notebook/static/components to match the previous installation location.

Most packages are identical, but a couple of packages have slightly different layouts (jquery-ui, react, xterm). It's unclear if these relative URLs should be considered public APIs, in which case we can make do more detailed renames to match everything exactly.

Related to #6210

minrk avatar Oct 25 '21 10:10 minrk

Thanks, @minrk! We'll review this in Wednesday's notebook meeting. 😎

Zsailer avatar Oct 25 '21 15:10 Zsailer

I think there's a real test failure, presumably related to a url somewhere or other that needs updating, but I haven't found it. Things seem to work when I test locally.

minrk avatar Oct 25 '21 17:10 minrk

I think there's a real test failure, presumably related to a url somewhere or other that needs updating, but I haven't found it.

@minrk - could you please point out the test failure (tests aren't very stable at the moment and I'm not sure what might be real or fake)? Perhaps someone could then take a look if there's a starting point.

kevin-bates avatar Jan 05 '22 15:01 kevin-bates

Closing this PR as an issue has been opened for this work on NbClassic, where this could be addressed.

RRosio avatar Aug 01 '23 01:08 RRosio