Make tabbing interface in formgrader more obvious

[svenuthe]

Operating system

Fedora

nbgrader --version

python 3.5.3 nbgrader 0.5.4

jupyterhub --version (if used with JupyterHub)

4.4.0

jupyter notebook --version

5.4.1

Expected behavior

After clicking "full credit" button, the button has the focus. Afterwards, scrolling with PgUp and PgDn is impossible in Firefox.

Actual behavior

After clicking "full credit" button, the number input has the focus.

Steps to reproduce the behavior

Click "full credit" button.

[jhamrick]

I think this is expected behavior. Can you explain why you would like the button to retain focus?

[svenuthe]

I use PgUp, PgDn Keys to scoll through the answers. If a number input has the focus, the PgUp, PgDn Key are loosing scrolling functionality. I am not sure, if this is a Firefox only behaviour.# The actual behaviour is not expected by any user: When I decide to give full credit, I click the button. There is no reason, any user (incl. me) expects that the input field is focused.

[jhamrick]

Ah, I see. Can I recommend that you use tab and shift+tab to navigate through the notebook instead? This was an early design decision that we made to make it easier to jump quickly through different problems, and has the advantage that you won't accidentally go too little or too far when trying to get to the next problem (as might happen with page up/page down).

However, one of the limitations of the tabbing interface is that it expects the focused object on the page to always be the points and comment boxes. By allowing focus on the buttons, this breaks the flow of tabbing, so unfortunately this change isn't really compatible with the current interface.

[svenuthe]

page up/page down does not skip content.

this change isn't really compatible with the current interface Yes, this would lead to a major change.

In terms of this issue, I would suggest to improve the interface: Make the "early design decision" more obvious to the user.