nbgrader icon indicating copy to clipboard operation
nbgrader copied to clipboard

Published 20 hours ago • verified publisher icon jupyter

Make hashing independent of notebook content

Open tuncbkose opened this issue 2 years ago • 2 comments

Currently, changing the content of a submitted notebook breaks feedback distribution (see some discussion in https://github.com/jupyter/nbgrader/issues/1202). This is because feedback distribution uses a hash that depends on the notebook content.

This pr aims to solve this issue by duplicating the timestamp.txt mechanism. A submission_secret.txt file containing a random string is created during submission, and the notebook hash is changed to depend only on this file and notebook name.

Should fix #1712

tuncbkose avatar Apr 06 '23 11:04 tuncbkose

Binder :point_left: Launch a Binder on branch AaltoSciComp/nbgrader/hash

github-actions[bot] avatar Apr 06 '23 11:04 github-actions[bot]

I like this solution and would also solve some of the issues I am facing!

danielmaitre avatar Nov 25 '23 09:11 danielmaitre

Thanks for the review. I'll rebase within a day or two and ping you

tuncbkose avatar Jun 18 '24 12:06 tuncbkose

@brichet rebased.

tuncbkose avatar Jun 19 '24 07:06 tuncbkose

Thanks @tuncbkose

brichet avatar Jun 20 '24 07:06 brichet

Happy to see this. :tada: Was manually applying the PR every update. Thanks @tuncbkose

LukasMueller187 avatar Jun 20 '24 07:06 LukasMueller187