Assignment names breaking regex

[perllaghu]

This extends the list of banned assignment-name characters beyond + to include a bunch that break the path regex code.

closes #1738

[github-actions[bot]]

:point_left: Launch a Binder on branch edina/nbgrader/assignment_names_breaking_regex

[brichet]

Thanks @perllaghu.

I wonder if there could not be a way to manage special characters when running the regex match. Something like re.escape, to avoid constraining the assignment name.

[brichet]

On my side there is some confusion in this PR, I see some modifications already in the branch main (e.g. zero point validation).

[perllaghu]

Thanks @perllaghu.

I wonder if there could not be a way to manage special characters when running the regex match. Something like re.escape, to avoid constraining the assignment name.

This is essentially an extension of the existing routine - which prevent + in assignment names.

[perllaghu]

On my side there is some confusion in this PR, I see some modifications already in the branch main (e.g. zero point validation).

I'll rebase on master :)

[smith-kyle]

Just a heads up, you can review notebook changes like this using GitNotebooks.

e.g. this pull request https://gitnotebooks.com/jupyter/nbgrader/pull/1768

It's free for public repos, so might be helpful for y'all.

[lahwaacz]

The last commit https://github.com/jupyter/nbgrader/pull/1768/commits/88915ab776de97b52d754d479709fbc36f84fa7b is very confusing: it includes changes from https://github.com/jupyter/nbgrader/commit/67069391deaf4ac390952e633926631b5271a328 (in main), reverts 2 previous commits in this pull request and maybe also some unrelated changes (I can't tell at this point).

Please do an interactive rebase, drop the reverted commits, squash corrections into previous commits and overall make sure that this pull request can be properly reviewed.

[brichet]

This is essentially an extension of the existing routine - which prevent + in assignment names.

Agree, let's move forward with this PR and open an issue to allow these character in future development. @perllaghu can you clean this PR please ?

[perllaghu]

The sane move now will be to drop this & redo the work on a fresh master