nbdime icon indicating copy to clipboard operation
nbdime copied to clipboard

Published 20 hours ago • verified publisher icon jupyter

fix `_compare_mimedata`

Open chrisjsewell opened this issue 5 years ago • 2 comments

Surprised this hasn't been noticed before. For example, this ensures minor modifications of image/svg+xml are not erroneously reported as deleted/inserted.

chrisjsewell avatar Aug 08 '19 03:08 chrisjsewell

For completeness, I also added comparison of application/json mimedata, using json.dumps

chrisjsewell avatar Aug 08 '19 03:08 chrisjsewell

I included the first commit in #543. I'm not sure if the JSON one makes sense, as we already have structured JSON differ :) At the very least, I think we would need to use a sorted JSON serializer to have it be reliable.

What are the advantages to diffing JSON outputs as strings as you see it?

vidartf avatar Sep 29 '20 10:09 vidartf