nbconvert icon indicating copy to clipboard operation
nbconvert copied to clipboard
verified publisher icon jupyter

Move the `check_release.yml` to its own workflow

Open jtpio opened this issue 1 year ago • 3 comments

  • [x] Move the check_release step to a separate workflow, so it's easier to see if it passes
  • [x] And add an extra step to upload the artifacts built by the releaser, so it's easier to test PRs locally by installing the built wheel from a branch.

jtpio avatar Nov 14 '24 10:11 jtpio

@martinRenou I was wondering if this was maybe ready to be merged?

Having the built artifacts could help test changes from other PRs more easily, for example https://github.com/jupyter/nbconvert/pull/2178.

jtpio avatar Dec 06 '24 10:12 jtpio

test_check does not pass because it is waiting for check_release:

https://github.com/jupyter/nbconvert/blob/6e5fdb31b77314a85f6ac199a92d4d1dc0f67f1d/.github/workflows/tests.yml#L161-L170

It would need to be removed from it and added as a separate protection rule

krassowski avatar Jan 02 '25 10:01 krassowski

It would need to be removed from it and added as a separate protection rule

Done in https://github.com/jupyter/nbconvert/pull/2191/commits/5541bdbd91bdd5af89b65764dc78f864ef3e48bb.

However I don't have access to the repo settings to enable the protection rule in case we want to add one (not sure if this may have an impact on the releaser though).

jtpio avatar Jan 02 '25 17:01 jtpio