nbclassic icon indicating copy to clipboard operation
nbclassic copied to clipboard

Test extension loading order

Open vidartf opened this issue 4 years ago • 2 comments

A remaining task from #56 was to add tests for the intended behavior. This issue tracks that.

vidartf avatar May 26 '21 09:05 vidartf

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively. welcome You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

welcome[bot] avatar May 26 '21 09:05 welcome[bot]

The sort logic is no more in nbclassic and implemented in notebook_shim https://github.com/jupyter/notebook_shim/blob/189915e9ff4b1c926c9439211fdf7f6767c1bb77/notebook_shim/nbserver.py#L84-L92

Should this issue be transferred to notebook_shim?

Also I wonder if the def _link_jupyter_server_extension(serverapp) is even used in notebook_shim as it is normally. a jupyter-server task. Should this be removed?

echarles avatar Oct 28 '22 05:10 echarles