nbclassic icon indicating copy to clipboard operation
nbclassic copied to clipboard

[CI] Fix or disable jobs to get a 100% green CI

Open echarles opened this issue 3 years ago • 2 comments

This is a meta issue to follow-up the needed work to get a 100% green CI. This main note will be updated to keep track of the progress and assignments.

  • [x] Doc Test / build https://github.com/jupyter/nbclassic/pull/99 @echarles
  • [x] Check Release / check_release https://github.com/jupyter/nbclassic/pull/102 @echarles
  • [ ] Check Release / link_check https://github.com/jupyter/nbclassic/pull/110 @echarles
  • [ ] Test Minimum Versions https://github.com/jupyter/nbclassic/pull/109 @echarles
  • [ ] Test Downstream / downstream https://github.com/jupyter/nbclassic/pull/110 @echarles

@RRosio @ericsnekbytes you can use the CI result shown on https://github.com/jupyter/nbclassic/pull/99 to inspect the failing jobs, pick the one you feel comfortable with and assign it to your self here. Thx!

Disabled tests

  • check-manifest is disabled (see tool.jupyter-releaser skip array in pyproject.toml) https://github.com/jupyter/nbclassic/pull/102#issuecomment-1134538106. The goal is to migrate to hatch when ready.
  • Excluded the services tests for the Linux JS Tests job matrix (see https://github.com/jupyter/nbclassic/pull/105#issue-1250109243). These tests will be revisited in a separate issue.
  • Test Minimum Version is disabled https://github.com/jupyter/nbclassic/pull/109

echarles avatar May 13 '22 16:05 echarles

Thank you! I will take a look at the following:

  • [x] CI Job Linux JS Tests / notebook and base test failures. https://github.com/jupyter/nbclassic/pull/103 @RRosio

  • Excluded the CI Job Linux JS Tests / services test failure. Will address in separate issue

RRosio avatar May 13 '22 19:05 RRosio

I'll take a look at these (related python 3.x tests for macos):

  • [ ] Testing nbclassic / build (macos, notebook).

ericsnekbytes avatar May 23 '22 19:05 ericsnekbytes