jupyter_core icon indicating copy to clipboard operation
jupyter_core copied to clipboard

migrate writes marker file in read only directory

Open robertlugg opened this issue 5 years ago • 1 comments

I have defined JUPYTER_CONFIG_DIR which points to a directory which is read only. When migration.py tries to "touch" a marker file, it fails. This makes placing your config file in a read-only location not possible (such as inside a container).

Please refer to this line: https://github.com/jupyter/jupyter_core/blob/b129001bb88abf558df5dfab791a5aeeba79e25c/jupyter_core/migrate.py#L247

My suggestion is to instead just silently fail if not possible to write.

robertlugg avatar Feb 06 '20 01:02 robertlugg

My suggestion is to instead just silently fail if not possible to write.

That makes sense to me. Can you submit a PR?

Is this the only issue you are seeing with a read only config directory?

jasongrout avatar Feb 06 '20 08:02 jasongrout