jupyter-packaging icon indicating copy to clipboard operation
jupyter-packaging copied to clipboard

package_data_spec not supported anymore?

Open martinRenou opened this issue 3 years ago • 4 comments

Being able to pass a package_data_spec to create_cmdclass was quite handy to be able to include package_data as part of the wheel, but it seems to me that it's not supported anymore, or maybe I am missing something?

martinRenou avatar May 08 '21 09:05 martinRenou

cf https://github.com/jupyter/jupyter-packaging/pull/69#issue-591751095

blink1073 avatar May 11 '21 13:05 blink1073

I am not sure I understand everything there, how should one include package_data in the wheel now? I can see we can still use the MANIFEST and include_package_data=True to include data in the source dist.

martinRenou avatar May 11 '21 14:05 martinRenou

The standard way: https://setuptools.readthedocs.io/en/latest/userguide/datafiles.html

blink1073 avatar May 11 '21 15:05 blink1073

We provide a get_data_files function but recommend people use setup.cfg for non-glob-pattern data files.

Under the main use of globbing a bunch of folders, I assume get_data_files should do it, but what is the recommended way to ensure that this is only called after the build commands have run ?

vidartf avatar May 17 '21 16:05 vidartf