enhancement-proposals
enhancement-proposals copied to clipboard
jupyter
Localizing Notebooks - continued
Continuation of: https://github.com/jupyter/enhancement-proposals/pull/10
Based on @TwistedHardware ’s commits. (I dropped the ones which modified the base template.)
Updated proposal for translation of Jupyter notebook. Please review/approve, as I'm able to work on this now that I'm back on the job.
I agree with Kyle. The best way to vet the approach is to try it out in a few PRs against notebook and adjust accordingly.
As for the proposal document, I took a quick read through. I want to go back and make a few minor suggestions.
Picking this up after the holiday. The only thing I have left is that this proposal is scoped only to "notebook classic" as opposed to JupyterLab, and I think the reverse makes a bit more sense. JupyterLab is the future of the notebook client, and the notebook package is heading for retirement pretty soon. Plus, the discussion of tooling sounds like it will fit better in the existing JupyterLab pipeline than the notebook classic one. What do people think about that?
My brain is rusty, I misunderstood the tooling question, because I read babel as babel. So that part doesn't seem relevant to notebook vs JupyterLab. Given that the server code is still the notebook package for both sides, I think this is a sensible proposal to start there.
Approved by me as-is.
Thanks, and while I understand that Jupyter lab is the future, "classic" is the present at least for us. I'm close to being ready for a preliminary PR on this, so I will welcome your comments and advice.
As long as @JCEmmons doesn't mind the fact that there may be a bit of work to be re-done for JLab, I'm +1 here. In fact, there may be some advantage in doing it in Classic so we can kick the tires of the process atop a fairly stable and simpler codebase. Lab is more complex and moving rapidly, so I suspect doing this in Lab right now could prove quite tricky.
@JCEmmons, since you seem OK with that, I'd say let's go ahead and see what we learn!
@minrk pinged the steering council (thanks!) for feedback, but we'll treat silence as acquiescence if we don't hear back from the rest in a few days. No need to stall you here, and very sorry for the delay. We really appreciate your contribution, and this is an important problem we've long failed to tackle.
Great - you can view the work in progress on this item at https://github.com/JCEmmons/notebook/tree/jep16. I am hoping to have a preliminary PR ready soon.
Regards,
John C. Emmons Globalization Architect & Unicode CLDR TC Chairman IBM Software Group Internet: [email protected]
From: Kyle Kelley [email protected] To: jupyter/enhancement-proposals [email protected] Cc: John Emmons/Austin/IBM@IBMUS, Mention [email protected] Date: 01/25/2017 11:44 PM Subject: Re: [jupyter/enhancement-proposals] Localizing Notebooks - continued (#16)
@rgbkrk approved this pull request. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.
I spotted a few minor things that I think should be fixed (see above). Once those are dealt with, I think we can merge this.
Sorry for the delay. Minor comments none of them blocking this. I'm pretty sure we can (and should) allow translation to be installed separately. I have no issue allowing some translation to be shipped with the notebook, but I believe if external translation are installed, we should pick these.
One other point about translating string I haven't seen is the use of {identifier} instead of %s (because translation may have a different order), but that's minor.
One more thing to think about : the notebook might not be the only package we need to localize for the UI to be fully localized.
There is a related proposal for bi-directional support in the notebook: https://github.com/jupyter/notebook/issues/2178
Hi @srl295 :wave:—Zach from the @jupyter/software-steering-council here.
We're working through old JEPs and closing proposals that are no longer active or may not be relevant anymore. Under Jupyter's new governance model, we have an active Software Steering Council who reviews JEPs weekly. We are catching up on the backlog now. Since there has been no active discussion on this JEP in awhile, I'd propose we close it here (we'll leave it open for two more weeks in case you'd like to revive the conversation). If you would like to re-open the discussion after we close it, you are welcome to do that too.
Keep in mind that JupyterLab (and Notebook v7) now includes a fairly robust internalization+localization system. If you have additional ideas to expand this system, free free to comment here anytime.
