docker-stacks
docker-stacks copied to clipboard
Improve logging in start.sh
Possible future improvements (just a note for someone, who will want to improve our docker stacks):
- Test
JUPYTER_DOCKER_STACKS_QUIET
env variable - Always add log_level like this: `_log "INFO" "my_message"
- Based on the log level color can be added
- Exit on fatal errors (or maybe just errors)
- Add timestamps, like
INFO[2021-08-23 11:00:00.000000] my_message
- Stop using bash, haha 👍
Based on comment: https://github.com/jupyter/docker-stacks/pull/1526#pullrequestreview-804768133
@mathbunnyru I think this should still stay open for a while?
Sure, reopened.