docker-stacks icon indicating copy to clipboard operation
docker-stacks copied to clipboard

Published 20 hours ago • verified publisher icon jupyter

Improve logging in start.sh

Open mathbunnyru opened this issue 4 years ago • 2 comments

Possible future improvements (just a note for someone, who will want to improve our docker stacks):

  1. Test JUPYTER_DOCKER_STACKS_QUIET env variable
  2. Always add log_level like this: `_log "INFO" "my_message"
  3. Based on the log level color can be added
  4. Exit on fatal errors (or maybe just errors)
  5. Add timestamps, like INFO[2021-08-23 11:00:00.000000] my_message
  6. Stop using bash, haha 👍

Based on comment: https://github.com/jupyter/docker-stacks/pull/1526#pullrequestreview-804768133

mathbunnyru avatar Nov 15 '21 16:11 mathbunnyru

@mathbunnyru I think this should still stay open for a while?

yuvipanda avatar Oct 17 '23 12:10 yuvipanda

Sure, reopened.

mathbunnyru avatar Oct 17 '23 12:10 mathbunnyru