cpp-terminal icon indicating copy to clipboard operation
cpp-terminal copied to clipboard

Published 20 hours ago • verified publisher icon jupyter-xeus

Window class update

Open MCWertGaming opened this issue 2 years ago • 2 comments

This PR updates the window class to handle 24bit / 8bit and 4bit colors in one implementation.

Fixes #128, #96, #107.

WIP: #108.

MCWertGaming avatar Aug 23 '22 22:08 MCWertGaming

Does this is superseded by your new PR?

flagarde avatar Sep 14 '22 22:09 flagarde

Well #191 implements #190, which isn't covered by this PR, but the whole auto color stuff comes from this PR.

The reason was that this PR gotten a bit over my head, so I rather split it into smaller things so the window class update can be easily merged without having a big mess of different color functions and everything.

So the plan is:

  • [x] Merge #191
  • [x] Apply the new Color functions into a unified Window class version (Currently there is one window class for 4bit and one for 24bit, while the 24bit class doesn't work on macos due to lack of support)
  • [x] Update the 24bit example to use the auto color function
  • [x] Probably also a cleanup and upgrading the Prompt to 24bit colors as well
  • [ ] Also the platform header should be pruned and simplified.

MCWertGaming avatar Sep 15 '22 08:09 MCWertGaming

@MCWertGaming does this PR should be closed ? The platform header should be pruned and simplified. could be solved in other PR (maybe creating an issue for this)

flagarde avatar Dec 17 '22 19:12 flagarde

Yeah I moved it into #213.

MCWertGaming avatar Jan 01 '23 15:01 MCWertGaming