pythreejs icon indicating copy to clipboard operation
pythreejs copied to clipboard

Upgrade to r112

Open akaszynski opened this issue 2 years ago • 6 comments

Upgrade to threejs r112.

Remaining wrappers

  • [x] ~PMREMGenerator~ (API changed from method to class, delaying wrapper)
  • [ ] LightProbe
  • [ ] LightProbeHelper
  • [ ] PositionalAudioHelper
  • [ ] SphericalHarmonics3
  • [ ] InstancedMesh
  • [ ] AmbientLightProbe
  • [ ] HemisphereLightProbe
  • [ ] PointLightShadow
  • [ ] WebGLMultisampleRenderTarget
  • [ ] WebGLMultiviewRenderTarget
  • [ ] DataTexture2DArray
  • [ ] WebGLMultiview

Changes

  • [ ] .drawMode has been removed

Bonus

  • Resolve #288 by adding a loader for CubeTexture. Need this for the light probe tests.

akaszynski avatar Apr 21 '22 18:04 akaszynski

@maartenbreddels, I'm going to try to support r112 first and then go from there.

@jasongrout, I'd like to help maintain this repository. Please message me at [email protected] if you think that's possible. I think this is an excellent repository and it's been 6 months since the last commit and around a year since a release. I'd really like to help.

akaszynski avatar Apr 21 '22 18:04 akaszynski

Awesome, thanks for volunteering! @vidartf is the current main maintainer. @vidartf?

jasongrout avatar Apr 21 '22 18:04 jasongrout

Codecov Report

Merging #376 (2a785f6) into master (a78cb57) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #376   +/-   ##
=======================================
  Coverage   70.86%   70.86%           
=======================================
  Files          23       23           
  Lines         834      834           
=======================================
  Hits          591      591           
  Misses        243      243           

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

codecov-commenter avatar Apr 21 '22 22:04 codecov-commenter

@jasongrout, I've not heard back from @vidartf and he's not been active on github as of late.

Is there any chance I can get hold of one of the other maintainers?

akaszynski avatar Apr 26 '22 15:04 akaszynski

@vidartf was in the ipywidgets dev meeting this morning, so pinging him again.

jasongrout avatar Apr 26 '22 18:04 jasongrout

Hi @akaszynski , I'm around, and I'm more than happy to have others help out here! Thanks for volunteering! I am going to do an effort on this repo in the few coming days to add support for ipywidgets 8, but do not really plan to be working on features beyond that, so happy to leave that to you!

If you need me on a quicker turn-around than me checking my GH pings, you should be able to find my email address on the commits. Let's get a few PR's/commits through, and then get you set up with commit/publish rights after. Did you want me to review this PR in its current state?

vidartf avatar Apr 29 '22 12:04 vidartf