jupyverse icon indicating copy to clipboard operation
jupyverse copied to clipboard

support embedding in iframes, perhaps via custom/custom.js

Open ajbouh opened this issue 2 years ago • 1 comments

Description

Based on https://jupyter-notebook.readthedocs.io/en/stable/public_server.html#embedding-the-notebook-in-another-website

One must add a custom/custom.js file to $JUPYTER_CONFIG_DIR:

define(['base/js/namespace'], function (Jupyter) {
  Jupyter._target = '_self';
});

Based on my initial experiments, it doesn't seem like this file is being included by Jupyverse into the served frontend. Is the expected? Intended?

The core thing I'm trying to do is use my jupyverse instance from within an iframe. Trying to use the above approach may be a dead-end. I'd be just as happy to do something else, like set a proper "url prefix" to use when opening links/new tabs from places like /retro/tree.

ajbouh avatar Apr 05 '23 22:04 ajbouh

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively. welcome You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

welcome[bot] avatar Apr 05 '23 22:04 welcome[bot]