jupyter_server
jupyter_server copied to clipboard
switch to jupyter_events
Replaces jupyter_telemetry with jupyter_events.
Telemetry is a more specific use case of the Jupyter Event System mentioned in #780, and it brings some extra constraints that won't be addressed by the (currently available) "event system" use-case. Telemetry might be added to Jupyter Server at a later time.
Codecov Report
Merging #862 (0028483) into main (0028483) will not change coverage. The diff coverage is
n/a.
:exclamation: Current head 0028483 differs from pull request most recent head 2f7ef4b. Consider uploading reports for the commit 2f7ef4b to get more accurate results
@@ Coverage Diff @@
## main #862 +/- ##
=======================================
Coverage 72.12% 72.12%
=======================================
Files 65 65
Lines 8044 8044
Branches 1343 1343
=======================================
Hits 5802 5802
Misses 1836 1836
Partials 406 406
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
@3coins and @kiendang—pinging you to let you know I've move most of the event handling logic from jupyter_telemetry into jupyter_events. We can start to deprecate these things in jupyter_telemetry.
@jupyter-server/jupyter-server-council this should be ready to go. Would someone mind reviewing+merging?
Are we not renaming "categories" first?
Ah, right. Yeah, let's settle that in jupyter_events before merging here. Thanks, @blink1073! I'll open a PR there later today.
Looks good! The changes are pretty lean, so I say we can just merge this after the pipeline passes.
Took a quick look at the failing tests here: https://github.com/jupyter-server/jupyter_server/runs/8020778443?check_suite_focus=true. It looks like there's an error when trying to dereference __class__.__name__. Likely something wrong with the test fixtures?
@Zsailer BTW, have we established a convention for where to place event schemas within the jupyter_server project? I was thinking just under /jupyter_server/schemas. Could you also paste the Contents Manager event schema you showed off during contributing hour into a Github Gist as an example for developers to refer to?