jupyter_server icon indicating copy to clipboard operation
jupyter_server copied to clipboard

docs: document the logging_config trait

Open oliver-sanders opened this issue 3 years ago • 2 comments

Addresses #684

~(will fail CI until Traitlets 5.2.1 is released)~

  • Bump minimum traitlets version from 5.1 to 5.2.1 (not yet released).
    • This gives us access to the logging_config trait.
    • Don't know if you want to bump the traitlets version or just add a note that this is a new feature of Traitlets 5.2.0.
    • Note Traitlets 5.2.0 has a couple of bugs so best to wait for 5.2.1 before advertising this.
  • Document how to use logging_config with Jupyter Server / extension applications.
    • Addresses #684
    • Provide examples for pointing Jupyter Server & extension application output at a file.

oliver-sanders avatar May 13 '22 12:05 oliver-sanders

I think depending on traitlets >= 5.2.1 sounds good, since this is targeting 2.0

blink1073 avatar May 16 '22 13:05 blink1073

Codecov Report

Base: 75.14% // Head: 75.14% // No change to project coverage :thumbsup:

Coverage data is based on head (884a47a) compared to base (cf902ea). Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #844   +/-   ##
=======================================
  Coverage   75.14%   75.14%           
=======================================
  Files          63       63           
  Lines        8225     8225           
  Branches     1635     1635           
=======================================
  Hits         6181     6181           
  Misses       1624     1624           
  Partials      420      420           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov-commenter avatar May 16 '22 13:05 codecov-commenter

(deconflicted)

oliver-sanders avatar Nov 15 '22 12:11 oliver-sanders

I pushed a change to increase the minimum to 5.3, since I had some difficulties with the 5.2.x traitlets releases 😅

blink1073 avatar Nov 15 '22 14:11 blink1073