jupyter_server icon indicating copy to clipboard operation
jupyter_server copied to clipboard

Filebrowser paging draft

Open cnydw opened this issue 4 years ago • 3 comments

Addressing issue https://github.com/jupyter-server/jupyter_server/issues/538

Added a page parameter to the request, to select the pages. The updated API is not mature , would love to hear suggestions.

cnydw avatar Jun 08 '21 15:06 cnydw

Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly. welcome You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

welcome[bot] avatar Jun 08 '21 15:06 welcome[bot]

Hi @cnydw, any updates on this? It'd be great to make the filebrowser experience more performant.

mwakaba2 avatar Aug 06 '21 18:08 mwakaba2

@mwakaba2 @vidartf

I made a simple update, however I feel my paging design is far from ideal. The paging design like https://github.com/jupyter-server/jupyter_server/issues/538#issuecomment-856884253 isn't very intuitive. Most file browsers don't have pages, instead they only utilize the scrollbar.

A better design would probably abandon the page selection, and will look just like the original file browser. When opening a folder, It will display a small number of files, and when the scrollbar moves to the end, it activates loading more items (if there is any). However this scrollbar activated design will probably not work with my current simple implementation in the jupyter_server backend.

More discussion with JupyterLab side is probably needed.

cnydw avatar Aug 06 '21 21:08 cnydw