jupyter_server icon indicating copy to clipboard operation
jupyter_server copied to clipboard

Wrong usage of i18n

Open Carreau opened this issue 1 year ago • 1 comments

jupyter_server/serverapp.py
2861:        info += _i18n(f"Jupyter Server {ServerApp.version} is running at:\n{self.display_url}")

jupyter_server/auth/identity.py
654:                self.log.info(_i18n(f"Wrote hashed password to {config_file}"))

At least those two usage are wrong; the f-string will be formatted before the call to internationalisation. It should be _i18n(...).format().

In general we could likely grep the codebase for i18n\([^'\")], and any non-literal string in i18n will be wrong.

Carreau avatar Dec 17 '24 12:12 Carreau

I would like to work on this issue. Checking if anyone else has already started on this. Pls let me know.

kjayan avatar Feb 11 '25 04:02 kjayan