jupyter_server icon indicating copy to clipboard operation
jupyter_server copied to clipboard

Why is compression false in prod webpack config?

Open suganya-sk opened this issue 3 years ago • 2 comments

Problem

While looking into the delivery of static assets (https://github.com/jupyterlab/jupyterlab/issues/13189), I noticed that compression is set to false here, even though it looks like a production configuration from the file name.

Is there a historical reason for this? May be the intention was to turn on compression at the server level? Any pointers to relevant discussions is helpful! I have a high-level understanding of the build process; pls redirect if I should be looking anywhere else.

PS - @krassowski is also looking into dynamic compression in tornado as part of https://github.com/jupyterlab/jupyterlab/issues/13189

There might not be an action item here if leaving compression to the server is the way to go but this will help making that call in the linked req.

suganya-sk avatar Oct 08 '22 04:10 suganya-sk

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively. welcome You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

welcome[bot] avatar Oct 08 '22 04:10 welcome[bot]

Hi, I just wanted to confirm whether you intended to open this issue on the jupyter-server repo? All the discussion seems to be about files and settings in the JupyterLab repo, so maybe it would be useful if you clarified which part of the dicussion is relevant to jupyter-server?

vidartf avatar Oct 12 '22 13:10 vidartf