jupyter-resource-usage icon indicating copy to clipboard operation
jupyter-resource-usage copied to clipboard

Define _jupyter_server_extension_paths for backward compatibility

Open casparvl opened this issue 3 years ago • 1 comments

Also, the __init__.py file used to contain

load_jupyter_server_extension = load_jupyter_server_extension

That doesn't seem to make sense, it's like x = x, that's a no-op. Probably you meant to do what was suggested here https://jupyter-server.readthedocs.io/en/latest/developers/extensions.html#migrating-an-extension-to-use-jupyter-server , also for backward compatibility.

For comparison, see e.g. https://github.com/jupyterhub/jupyter-server-proxy/blob/099fce21feed4c5c762740dea2d34c5ca548c5b3/jupyter_server_proxy/init.py#L51

casparvl avatar Jul 08 '22 16:07 casparvl

Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly. welcome You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

welcome[bot] avatar Jul 08 '22 16:07 welcome[bot]

Ping on this one: is there anything blocking the merge of this fix?

casparvl avatar Sep 30 '22 09:09 casparvl

Thanks @casparvl this looks good :+1:

Waiting for the CI fix to complete in https://github.com/jupyter-server/jupyter-resource-usage/pull/145. We can then rebase this PR and merge it.

jtpio avatar Sep 30 '22 16:09 jtpio

@jtpio I accidentally removed my fork for this. I saw you rebased my other PR based on #145 . Can you still do the same for thise one so that it can be merged? Or is that impossible now that more fork disappeared? If the 2nd: any suggestion on how we best proceed? It's a one-line change, if needed I can recreate it in a new fork (or you can, whichever you prefer)...

casparvl avatar Oct 04 '22 15:10 casparvl

@casparvl maybe the best would be to create a new branch on your fork with this change, and open a new PR.

jtpio avatar Oct 04 '22 15:10 jtpio

Closing in favour of https://github.com/jupyter-server/jupyter-resource-usage/pull/148

casparvl avatar Oct 04 '22 16:10 casparvl