jupyter-resource-usage
jupyter-resource-usage copied to clipboard
Define _jupyter_server_extension_paths for backward compatibility
Also, the __init__.py file used to contain
load_jupyter_server_extension = load_jupyter_server_extension
That doesn't seem to make sense, it's like x = x, that's a no-op. Probably you meant to do what was suggested here https://jupyter-server.readthedocs.io/en/latest/developers/extensions.html#migrating-an-extension-to-use-jupyter-server , also for backward compatibility.
For comparison, see e.g. https://github.com/jupyterhub/jupyter-server-proxy/blob/099fce21feed4c5c762740dea2d34c5ca548c5b3/jupyter_server_proxy/init.py#L51
Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:
Ping on this one: is there anything blocking the merge of this fix?
Thanks @casparvl this looks good :+1:
Waiting for the CI fix to complete in https://github.com/jupyter-server/jupyter-resource-usage/pull/145. We can then rebase this PR and merge it.
@jtpio I accidentally removed my fork for this. I saw you rebased my other PR based on #145 . Can you still do the same for thise one so that it can be merged? Or is that impossible now that more fork disappeared? If the 2nd: any suggestion on how we best proceed? It's a one-line change, if needed I can recreate it in a new fork (or you can, whichever you prefer)...
@casparvl maybe the best would be to create a new branch on your fork with this change, and open a new PR.
Closing in favour of https://github.com/jupyter-server/jupyter-resource-usage/pull/148