jupyter-resource-usage icon indicating copy to clipboard operation
jupyter-resource-usage copied to clipboard

Published 20 hours ago • verified publisher icon jupyter-server

Allow users to opt out of prometheus metrics

Open dleen opened this issue 3 years ago • 1 comments

Poor mans fix for #123

dleen avatar Apr 06 '22 22:04 dleen

Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly. welcome You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

welcome[bot] avatar Apr 06 '22 22:04 welcome[bot]

@kevin-bates good suggestion! done!

dleen avatar Aug 22 '22 17:08 dleen

Hi @jtpio - I'm hoping you might be able to give this PR some attention relative to its review/merge/release as it will alleviate some heartburn for others.

In looking into this, I found that the lint tooling must have changed over (I'm assuming) its last major release and have provided PR #138 to address the linting failures evident on the various PRs - so it might be helpful to review/merge that PR prior to others.

I you need help, or I should be reaching out to someone else, please let me know. Thank you.

kevin-bates avatar Aug 22 '22 21:08 kevin-bates

Thanks @kevin-bates for the ping, this looks good.

I used the GitHub button to rebase the branch to make sure to grab the fixes from https://github.com/jupyter-server/jupyter-resource-usage/pull/138:

image

Also this repo is compatible with the Jupyter Releaser so we can make a 0.6.2 release after merging this.

Actually @kevin-bates if you would like to make the release feel free to proceed. You should have publish access to PyPI already. And I can add you to npm if you give me your username (the JupyterLab extension is also published to npm for consistency): https://www.npmjs.com/package/@jupyter-server/resource-usage

jtpio avatar Aug 23 '22 13:08 jtpio

Congrats on your first merged pull request in this project! :tada: congrats Thank you for contributing, we are very proud of you! :heart:

welcome[bot] avatar Aug 23 '22 13:08 welcome[bot]

Hi @jtpio. I'm sorry, I don't currently have the bandwidth to revisit the jupyter-releaser stuff (I've used it once, probably late last year) and wouldn't want to mess things up. If you're unable to get to this in the next couple of days, I could probably spend some time with it on Friday. FWIW, my npm username is kbates.

kevin-bates avatar Aug 23 '22 14:08 kevin-bates