awesome-notebooks icon indicating copy to clipboard operation
awesome-notebooks copied to clipboard

FFMPEG - make dynamic graph videos

Open jravenel opened this issue 3 years ago • 13 comments

Following Thom Ives, Ph.D. post on Linkedin, the idea is to be able to generate dynamic graph videos with a generic notebook template.

Scope of work to be developed, following Naas template framework (input/model/output)

jravenel avatar Dec 11 '21 18:12 jravenel

Should this notebook emulate the same code like in the post ?

Neelaksh-Singh avatar Dec 12 '21 06:12 Neelaksh-Singh

@Neelaksh-Singh Yes with little changes. The idea is to be able to format it according to the naas framework (template is at the root of the repo) = we should have an input, model, and output sections + follow the naming convention "Tool_action"

jravenel avatar Dec 12 '21 08:12 jravenel

Sure I would like to work on it.

Neelaksh-Singh avatar Dec 12 '21 14:12 Neelaksh-Singh

@Neelaksh-Singh sure, I have added you to the naas contributor group.

Here are the steps to contribute:

1→ Open free account on Naas.ai 2→ Clone awesome-notebooks repo 3→ Change status of this Issue to "In progress" so we can know you are working on it 4→ Create new branch FFMPEG 5→ Create folder FFMPEG in awesome-notebooks folder, and adapt notebook template to the current use case (check out how Linkedin templates are done for example) 6→ Once you are happy with the result, commit to the branch 7→ Open a pull request and tag me as a reviewer with a little comment on what you have done, but most of the explanations should be in the notebook itself 8→ Change status of this Issue to "Review" so we can know a review is pending 9→ Link the PR to this issue for tracking in the backlog 10→ Expect a feedback and merge in the next 48h :)

jravenel avatar Dec 13 '21 13:12 jravenel

@Neelaksh-Singh just assigned you to the task. Feel free to ask questions or call for help!

jravenel avatar Dec 14 '21 11:12 jravenel

Hi, I was working on this issue on the Naas manager, when my credits got expired. I would try to resolve this issue locally from my system.

Neelaksh-Singh avatar Dec 15 '21 10:12 Neelaksh-Singh

Hey @Neelaksh-Singh , no problem we can add more credits to your account, just tell me the email you use please!

jravenel avatar Dec 15 '21 11:12 jravenel

It's [email protected]

Neelaksh-Singh avatar Dec 15 '21 11:12 Neelaksh-Singh

I added more credits to your account @Neelaksh-Singh, should be update in 15min.

jravenel avatar Dec 15 '21 13:12 jravenel

Hey @Neelaksh-Singh I did not manage to use it on my Naas.ai account, the apt-get sudo command don't work, and it's normal. But I'm also wondering if all of this is necessary.

Did you try youself? Can we make a review and peer-programming session (15min) to sort this out? Here is my calendly https://calendly.com/jeremyravenel

jravenel avatar Dec 21 '21 18:12 jravenel

Hi, since I am out of town till the New Year, I won't be able to schedule a meeting.

But I'm also wondering if all of this is necessary

As I was trying to emulate the same code as in the post, these libraries were required for our dataset generation. In the notebook, under the variable section, I have mentioned that if the user already has their dataset, then they may import it. Maybe for clarity, I can put a comment in the Installing Packages so that only the ones who are using the notebook for testing purposes should install the above packages.

Did you try youself?

I did try running on the Colab notebook, where it worked without any errors. When I tried running it in the Naas manager, it asked me for an FTP password (maybe for using sudo).
You may access the Colab file here

Neelaksh-Singh avatar Dec 22 '21 04:12 Neelaksh-Singh

@Neelaksh-Singh No problem I will try to fix and simplify the image generation part. I will update your PR and let you know.

Is that ok?

jravenel avatar Dec 22 '21 06:12 jravenel

Sure

Neelaksh-Singh avatar Dec 23 '21 19:12 Neelaksh-Singh