awesome-notebooks icon indicating copy to clipboard operation
awesome-notebooks copied to clipboard

Add message with link of the template when PR is merged

Open jravenel opened this issue 2 years ago • 8 comments

When a PR is merged, the CI (github action) should add a message to the PR (and if possible in the Issue as well) saying "The template is now available on the master branch on this link: https://github..... "

jravenel avatar Oct 15 '22 15:10 jravenel

@SuhasBRao do you want to keep up working on the CI?

jravenel avatar Oct 15 '22 15:10 jravenel

Sure, I would love to. Do I need to create a PR comment.

SuhasBRao avatar Oct 15 '22 16:10 SuhasBRao

Sure, I would love to. Do I need to create a PR comment.

Yes that's the idea.

jravenel avatar Oct 15 '22 16:10 jravenel

Cool, And what exactly do I need to link. Is it a link to .ipynb file that solves the issue

SuhasBRao avatar Oct 15 '22 16:10 SuhasBRao

Yes to the ipynb file in master branch that solve issue

jravenel avatar Oct 15 '22 16:10 jravenel

Okay, I will work this issue.

SuhasBRao avatar Oct 15 '22 16:10 SuhasBRao

@jravenel, is this the kind of comment you asked for.

Screenshot from 2022-10-18 19-10-32

This generates comment only if .ipynb file is detected in PR chagnes and when that PR is merged to master branch.

SuhasBRao avatar Oct 18 '22 13:10 SuhasBRao

@jravenel let me know what you think about this so I can modify it as required.

SuhasBRao avatar Oct 21 '22 09:10 SuhasBRao

@jravenel, I think you missed the last comment of @SuhasBRao ! The proposition seems good. Do you agree ?

FlorentLvr avatar Nov 29 '22 08:11 FlorentLvr

Hi @SuhasBRao, happy new year. We discussed about it with the team during the team and we think that to make this more useful, we need to use OpenAI to generate automatically and propose linkedin and twitter post. Wanna work on this update?

jravenel avatar Jan 05 '23 16:01 jravenel

Thanks a lot @jravenel, wish you the same. That sounds great, but i don't have much exposure on OpenAI. I might need to time to learn few things.

SuhasBRao avatar Jan 08 '23 05:01 SuhasBRao

✌️

jravenel avatar Jan 08 '23 06:01 jravenel

Do you need help on this @SuhasBRao we are moving it next week iteration FYI/.

jravenel avatar Feb 02 '23 16:02 jravenel