awesome-notebooks icon indicating copy to clipboard operation
awesome-notebooks copied to clipboard

Generate contribution certificate when PR is merged

Open jravenel opened this issue 2 years ago • 9 comments

As a contributor, anytime my PR is successfully merged into awesome-notebooks repo, I would like to receive a github notification in the comment that my PR was merged + certificate.

"Thank you for your contribution @slug, your PR has been merged into the master branch of awesome-notebook. Here is the contribution certificate you can share on social media so everybody knows how awesome you are 🤙🌎. Spread the #opensource love 💚" + image of the certificate.

Reference: https://github.com/jupyter-naas/awesome-notebooks/blob/master/Pillow/Pillow_Generate_A_Certificate_Template.ipynb

The idea is to add a generate_certificate.yaml inside the following folder: https://github.com/jupyter-naas/awesome-notebooks/tree/master/.github/workflows

jravenel avatar Oct 10 '22 12:10 jravenel

@SuhasBRao maybe you would like to look at this when you created the PR.

Is it something you are comfortable with?

jravenel avatar Oct 10 '22 12:10 jravenel

Yes, I will work on it.

SuhasBRao avatar Oct 10 '22 14:10 SuhasBRao

Cool 👍 @Dr0p42 can help if you need

jravenel avatar Oct 10 '22 14:10 jravenel

I might need help while creating a workflow

SuhasBRao avatar Oct 10 '22 14:10 SuhasBRao

no problem, just prepare a PR as you think it should be and @Dr0p42 will check and answer questions based on the PR. The essential point here is to commit your work and try to be as explicit as you can be in the questions 🤙 🔥🔥

no problem, just prepare a PR as you think it should be and @Dr0p42 will check and answer questions based on the PR. The essential point here is to commit your work and try to be as explicit as you can be in the questions 🤙 🔥🔥

jravenel avatar Oct 10 '22 14:10 jravenel

@jravenel is there a way to modify variables used in .ipynb using .yaml. To generate a certificate I need to modify certain variables like date_of_contribution, contributor_name etc.

SuhasBRao avatar Oct 10 '22 15:10 SuhasBRao

I think it should be a copy of your code from the .ipynb, not the same so you can do what you want

jravenel avatar Oct 10 '22 15:10 jravenel

@jravenel I solved it instead of making requests from .py I used API's in .yaml file, Heres the output. Let me know what you think I will create a PR. Screenshot from 2022-10-14 11-28-58

SuhasBRao avatar Oct 14 '22 05:10 SuhasBRao

Let's go for the PR!! that's awesome man! put @Dr0p42 and myself as reviewer please

jravenel avatar Oct 14 '22 15:10 jravenel

@SuhasBRao after discussion internally, we are not going to do it now (not a priority to follow this new process on top of what we are already doing) but we may reopen it later.

jravenel avatar Nov 07 '22 13:11 jravenel