declarativewidgets_explorer icon indicating copy to clipboard operation
declarativewidgets_explorer copied to clipboard

Resize issues with urth-viz-explorer

Open peller opened this issue 8 years ago • 1 comments

Follow-up to #2, which enables urth-viz-vega to resize based on its container

  1. urth-viz-explorer expands to fit the width of the notebook, but in dashboard mode, where the height of the cell changes, the explorer does not expand. This is because the notebook's output divs have no explicit sizing. We could look up the DOM to the div.cell and set the size to match that. All other widgets must have the same problem?
  2. Also, the collapsible cards may overlap with the cell in dashboard mode. Should overflow be hidden or scroll? Potentially needs to be set both for uses of urth-viz-explorer and also urth-viz-query independently.
  3. (actually an urth-viz-vega issue) The resize behavior of vega-lite currently assumes width and height are the size of the plot area and does not account for axes or labels. We've worked around this with a padding fudge factor of 150px. See vega/vega-lite#1496, vega/vega-lite#1497

peller avatar Aug 18 '16 17:08 peller

All other widgets must have the same problem?

Yes, I've seen the problem with other widgets such as the globe.

Should overflow be hidden or scroll?

Only if there is a use case where the explorer is expected to be used with the query in dashboard view. This also raises the question of whether the expand/JSON buttons should be displayed in dashboard view.

dalogsdon avatar Aug 19 '16 15:08 dalogsdon