corgi icon indicating copy to clipboard operation
corgi copied to clipboard

Both fatih/color and defined consts for shell colors?

Open andres-lowrie opened this issue 6 years ago • 1 comments

Hello

Was curious as to why you're using both the fatih/color package and the escape characters defined in the util package

https://github.com/DrakeW/corgi/blob/develop/util/util.go#L23

For example in this file they're both being used:

const values here https://github.com/DrakeW/corgi/blob/develop/snippet/step.go#L62

and the color package here https://github.com/DrakeW/corgi/blob/develop/snippet/step.go#L96

I can create a Pull request consolidating the usage to the fatih/color package but before doing so I wanted to check to see if there was something I'm missing in terms of a need for both of them

andres-lowrie avatar Sep 09 '18 20:09 andres-lowrie

hi @andres-lowrie , the escape chars are only used for exporting to shell script, if you can make them consistent by using the color package and keep output color printed when executing the exported shell script, please go ahead and open a PR!

junyu-w avatar Sep 13 '18 04:09 junyu-w