Jun Liu
> @apwojcik HIP tidy is complaining about `ctuOneDefinitionRuleViolation`, could you help to fix that? This problem still exists, please check the latest CI status. Thanks!
@apwojcik are we still working on this change requested?
@CAHEK7 @atamazov @pfultz2 last call of review. Thanks!
@bghimireamd `GroupConv3D_BackwardWeights_half_Bilinear_Suite` is producing NaN, please check
@bghimireamd please help to resolve the conflicts. Thanks!
@cderb it seems that somehow #2870 is not effective in this PR's CI?
> > @cderb it seems that somehow #2870 is not effective in this PR's CI? > > I'll clean up here. Starting debug. @cderb a few tests are still failing...
> @junliume It appears there are additional tests above what was addressed in #2870 which will hang when xnack is set manually in the environment by HSA_XNACK=1. @cderb should we...
> xnack+ make check now passing on machine with modified grub. Hopefully we can make it pass with the CI stage, do we know why it is still failing? http://micimaster.amd.com/blue/organizations/jenkins/MLLIBS%2FMIOpen/detail/xnack/15/pipeline
@CAHEK7 @amberhassaan @JehandadKhan re-request review