Jun Komoda

Results 340 comments of Jun Komoda

CIs are passed. memo https://ci.appveyor.com/project/cfarrow/comtypes/builds/47271940 https://github.com/enthought/comtypes/actions/runs/5230311902/jobs/9443793826?pr=486 https://ci.appveyor.com/project/pywinauto/pywinauto/builds/47271962

@vasily-v-ryabov Please review this. Not to break backwards compatibility, but since this is more of a "feature addition to allow named arguments to be passed" than a "bug fix for...

Thank you so much for the compliment, @bennyrowland! This issue is worth to be pinned (so I actually did). I will summarize my opinions during my free time this weekend.

First of all, most of the modern tools you have exemplified are for Python3 only. So if we were to adopt some of them, it would be the `drop_py2` branch,...

Just IMO ## formatters like [`black`](https://pypi.org/project/black/) This has already been partially introduced in the `drop_py2` branch(#418). [The GHA checks if the PRed code is in the `black==22.12.0` format](https://github.com/enthought/comtypes/blob/532c3996e73866009249e02981d3ead9ae58d474/.github/workflows/autofmt.yml#L24-L25). I am...

I am aware that supporting Python2 will be available up to [`1.2.x`](https://github.com/enthought/comtypes/milestone/3), and supporting Python3 only will be available from [`1.3.0`](https://github.com/enthought/comtypes/milestone/4). > the day `drop_py2` becomes `main` is not too...

## Moving to [`pyproject.toml`](https://peps.python.org/pep-0518/#file-format) Currently, [the AppVeyor CI](https://github.com/enthought/comtypes/blob/dac3a12251628049e7f90e73ebb774295dd898a1/appveyor.yml#L30-L32) and [the `test_pip_install`](https://github.com/enthought/comtypes/blob/dac3a12251628049e7f90e73ebb774295dd898a1/test_pip_install.py#L24) depend on the `setup.py`. If these tests can be run equivalently using the `pyproject.toml` instead of `setup.py`, I have...

> adding a pre-commit config file that devs can use to install a commit hook that will run `black` (and optionally other things) locally before committing would be a good...

When implementing #486, I considered that registering TLBs/DLLs for testing in the registry before testing and unregistering them after testing is better than worrying about native COM libraries in the...

@bennyrowland Thanks. I think your examples should be very useful. > Obviously getting the right `regsvr` is important, in my case I know I am 32-bit so just hard-coded it...