Junjie ZHANG
Junjie ZHANG
那如果要使用system的话，如何拼接数据比较好呢？
> > 那如果要使用system的话，如何拼接数据比较好呢？ > > 个人理解，instruction相当于给模型的指示，你将它放在正常assistant的前面就行了。 那就是先放在第一个assistant和第一个query放一起
@jaredcasper @deepakn94 Could you help me on this one?
It seems that "consumer_group_id" should be added into this `enum` at [this file](https://github.com/apache/apisix-dashboard/blob/ad697c643908faf99fb33a0970f6d95573fcca87/api/conf/schema.json#L4270)
> This PR is super interesting to me! Instead of supporting a ton of individual models, a quick way to enable TorchTitan is to use models loaded from Huggingface and...
> I see you are almost creating a copy of entire torchtitan under this folder. Instead, could you reuse existing files and functions (via `import`) as much as possible? E.g....
> > I see you are almost creating a copy of entire torchtitan under this folder. Instead, could you reuse existing files and functions (via `import`) as much as possible?...
@tianyu-l Hi, I've updated readme in https://github.com/pytorch/torchtitan/pull/919/commits/91838de487f807bacf4a38fb211d1a8133016fca and reply all your comments. Please have a look.
@wconstab pp issue fixed and tested with https://github.com/pytorch/torchtitan/pull/919/commits/accfa1f31834372323bbfd14104753ead8905a8d#diff-f3ae151a2c757861e79894d650697214e593188396134823440371457ed71ed3 .
@tianyu-l CP tested with FSDP2 TP2 CP2. 