Add withPosition() factory method to FileSource

[lslonina]

• Refactor creation to avoid redundant canonicalization calls
• Introduced internal factory methods for clearer construction paths

Overview

---

I hereby agree to the terms of the JUnit Contributor License Agreement.

---

Definition of Done

• [ ] There are no TODOs left in the code
• [ ] Method preconditions are checked and documented in the method's Javadoc
• [ ] Coding conventions (e.g. for logging) have been followed
• [ ] Change is covered by automated tests including corner cases, errors, and exception handling
• [ ] Public API has Javadoc and @API annotations
• [ ] Change is documented in the User Guide and Release Notes

[mpkorstanje]

I'm not sure why my review got posted twice. I've hidden one, but now they're both hidden. :confused:

[ALUMINIS650]

how to add?

[lslonina]

@mpkorstanje Thanks for the feedback — the code can definitely be simplified, especially with the instance method approach. Let’s see how the discussion on this topic evolves; I’ll keep this marked as a draft for now.

[mpkorstanje]

@mpkorstanje Thanks for the feedback — the code can definitely be simplified, especially with the instance method approach. Let’s see how the discussion on this topic evolves; I’ll keep this marked as a draft for now.

@lslonina the issue has moved off team discussion. Do you have time available to patch up your PR or would you prefer to hand it over?

[lslonina]

Thanks for picking this up. I’ve added @API(status = EXPERIMENTAL, since = "6.0"), but if this is a backport candidate, should we change it to since = "5.13.5" instead?

[marcphilipp]

Thanks for picking this up. I’ve added @API(status = EXPERIMENTAL, since = "6.0"), but if this is a backport candidate, should we change it to since = "5.13.5" instead?

Good question! Please keep using 6.0. We'll adjust it when backporting.

[marcphilipp]

@lslonina Are you going to finish this PR or is @mpkorstanje taking over?

[marcphilipp]

Thanks, @lslonina! :+1: