junit5
junit5 copied to clipboard
junit-team
Add ability for InvocationInterceptor to intercept argument providers
Quarkus needs to run tests in its own ClassLoader, and it achieves this by intercepting all methods through InvocationInterceptor and redirecting them to a new test instance loaded from the Quarkus ClassLoader.
This works really well with the exception of @MethodSource based parameters. As there is no way to intercept that the method is invoked on the original instance, and the parameters may be loaded from the wrong ClassLoader.
It would be great if we could have some additional methods added to InvocationInterceptor to intercept this invocation as well.
Related Issues
- #1139
- #2191
Tentatively slated for 5.8-M2 solely for the purpose of team discussion
One of the challenges here is that MethodArgumentsProvider (which invokes the @MethodSource factory method on the test instance) is an implementation of org.junit.jupiter.params.provider.ArgumentsProvider which is not an Extension API in junit-jupiter-api.
Whereas, InvocationInterceptor is an Extension API in junit-jupiter-api.
Thus, InvocationInterceptor cannot know about ArgumentsProvider.
We could add a new interceptExtensionMethod(Invocation<T> invocation, ReflectiveInvocationContext<Method> invocationContext, ExtensionContext extensionContext) method to InvocationInterceptor, and a MethodInvoker getMethodInvoker() method to ExtensionContext with interface MethodInvoker { Object invokeMethod(Method method, Object target, Object... args); }. Then, MethodArgumentsProvider could use MethodInvoker to call the configured method while InvocationInterceptor would be able to do what it needs.
@marcphilipp, your proposal is somewhat related to #2191.
If we implement a solution for #2191, that would likely result in a means for invoking any method using parameter resolvers, analogous to what org.junit.jupiter.engine.execution.ExecutableInvoker does internally.
So there may be room for synergies here.
This issue has been automatically marked as stale because it has not had recent activity. Given the limited bandwidth of the team, it will be automatically closed if no further activity occurs. Thank you for your contribution.
![stale[bot] avatar](https://avatars.githubusercontent.com/in/1724?v=4 "Published by a pub.dev verified publisher"){kind=small}
This is not stale. Quarkus is still waiting for this and has to apply brittle object cloning as a workaround.
I think we should address #3028 first as it might solve the problem more cleanly.
@stuartwdouglas Could you please point us to Quarkus' InvocationInterceptor implementation for reference?
@marcphilipp you can find the main usage in https://github.com/quarkusio/quarkus/blob/2.13.3.Final/test-framework/junit5/src/main/java/io/quarkus/test/junit/QuarkusTestExtension.java.
As you see in the various intercept methods use an instance of the test class created by Quarkus (which is created in interceptTestClassConstructor)
I should also add for context that Quarkus needed to go down this route, because it applies various transformations to classes and without using a custom ClassLoader and different test instance, the transformations could fail to be applied.