python-slack-logger icon indicating copy to clipboard operation
python-slack-logger copied to clipboard

Package wheel contains unexpected Python files

Open dahlia opened this issue 8 years ago • 1 comments

It contains slack_handler/__init__.py and slack_logger/__init__.py besides slack_logger.py.

$ pip3 download slack-logger==0.3.0
Collecting slack-logger==0.3.0
  Using cached slack_logger-0.3.0-py3-none-any.whl
  Saved ./slack_logger-0.3.0-py3-none-any.whl
Successfully downloaded slack-logger
$ tar xvfz slack_logger-0.3.0-py3-none-any.whl
x slack_logger.py
x slack_handler/__init__.py
x slack_logger/__init__.py
x slack_logger-0.3.0.dist-info/DESCRIPTION.rst
x slack_logger-0.3.0.dist-info/metadata.json
x slack_logger-0.3.0.dist-info/top_level.txt
x slack_logger-0.3.0.dist-info/WHEEL
x slack_logger-0.3.0.dist-info/METADATA
x slack_logger-0.3.0.dist-info/RECORD

slack_logger/__init__.py is even not a duplicate of slack_logger.py, but a previous version of it:

$ diff slack_logger.py slack_logger/__init__.py | head -n 10
8c8
<     def __init__(self, url, username=None, icon_url=None, icon_emoji=None, channel=None, mention=None):
---
>     def __init__(self, url, username=None, icon_url=None, icon_emoji=None, channel=None):
16d15
<         self.mention = mention and mention.lstrip('@')
19,20d17
<         text = self.format(record)
<
24c21

The worst problem is that import slack_logger doesn't see slack_logger.py but slack_logger/__init__.py which is outdated:

>>> import slack_logger
>>> slack_logger.SlackHandler('https://...', mention='U012ABC34')
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
TypeError: __init__() got an unexpected keyword argument 'mention'

dahlia avatar Dec 20 '17 12:12 dahlia

@dahlia Sorry, there was a problem when I packaging wheel. I just uploaded a new version to pypi. Can you try the latest version?

junhwi avatar Dec 20 '17 18:12 junhwi