Christoph Junghans comments

Results 288 comments of


                                            Christoph Junghans

[csg] Create option for defining residue name/type and residue id/number

@jkrajniak wrote the xml topology reader, so he might have an opinion.

Improve CI support for power9 and other architectures

https://docs.travis-ci.com/user/multi-cpu-architectures

Where to put private header files

> Should they be located in src/include? Why not just `src/libxtp` or `src/tools` like we do in `csg`? > We could also adjust the header guards e.g. > > ```...

Fixes parsing of `wdiff` output

Thanks for the report and the fix, I will test this on OSX, whose `sed` is slightly different, and then merge it.

Fixes parsing of `wdiff` output

Hmm, OSX it says: ``` ": RE error: repetition-operator operand invalid ``` replace `.*?` to something like `.*` works, so it seems BSD sed doesn't implement `.*?` even with `-E`.

Fixes parsing of `wdiff` output

It might be better to replace the whole `color_filter()` with `wdiff -w "$RED" -x "$OFF" -y "$GREEN" -z "$OFF"`.

Fixes parsing of `wdiff` output

> Yes, I think so, too. AFAICS, only `wdiff` knows where the diffs start and end, and parsing the output of `wdiff` will fail, even with non-greedy regular expressions –...

Line ending with `{` is flipped to `}`

@lemzwerg I haven't used cwdiff for years, do you want to take it over?

Line ending with `{` is flipped to `}`

No worries, I remember that #7 failed on OSX back when, hence I didn't merge it, but I might need to try it again.

Headers output separate from their diff...

Do you have an example of what you would except vs. what you got?