gofpdf icon indicating copy to clipboard operation
gofpdf copied to clipboard

[go modules] Move gofpdf/contrib to new repo / module

Open brunetto opened this issue 6 years ago • 2 comments

New issue generated by the discussion starting from here.

Summary:

  • The gofpdf package only depends on the standard library
  • Having the gofpdf/contrib packages in the same module of the gofpdf package breaks the use of modules
  • Moving the gofpdf package in a subfolder separating the modules is not an option because it implies breaking other projects
  • The best solution found is to move the gofpdf/contrib packages in a separate repo => they will become a new module

brunetto avatar Sep 21 '18 15:09 brunetto

Good summary, @brunetto. Thanks.

Are there any ideas on how to minimize the disruption of this change for users that require one or more of the packages in contrib?

jung-kurt avatar Sep 21 '18 20:09 jung-kurt

I'm not sure the contrib should go outside, it will be more work to make them in sync with gofpdf. It doesn't break go.mod, it's a feature for reproductibility. https://github.com/golang/go/wiki/Modules#why-does-go-mod-tidy-record-indirect-and-test-dependencies-in-my-gomod

There are still open discussions to decide what to do with indirect dependencies. Maybe they will stay but move in the end of the file or somewhere else ? Also they are not pulled if not needed by the app i think.

I believe we can wait and don't worry if go.mod has more dependencies than needed for simple use.

flibustenet avatar Nov 13 '18 17:11 flibustenet