fzf icon indicating copy to clipboard operation
fzf copied to clipboard

key-bindings files are not installed on ubuntu 21.04

Open roeniss opened this issue 3 years ago • 5 comments

  • [x] I have read through the manual page (man fzf)
  • [x] I have the latest version of fzf
  • [x] I have searched through the existing issues

Info

  • OS
    • [x] Linux (ubuntu 21.04)
    • [ ] Mac OS X
    • [ ] Windows
    • [ ] Etc.
  • Shell
    • [x] bash
    • [x] zsh
    • [x] fish

Problem / Steps to reproduce

Expected

I tried to enable key-bindings with oh-my-zsh's fzf plugins, which enables key-binding.zsh by omz framework.

Actual

error occurred:

setup_using_debian_package:source:32: no such file or directory: /usr/share/doc/fzf/examples/key-bindings.zsh

I didn't specify that path. the fzf plugin finds key-binding file path by itself.

So I simplify the problem like this to see what's going on:

docker run --rm -it ubuntu:21.04
apt update && apt install -y fzf tree
fzf --version
# 0.24 (devel)
dpkg -L fzf | grep binding
# /usr/share/doc/fzf/examples/key-bindings.bash
# /usr/share/doc/fzf/examples/key-bindings.fish
# /usr/share/doc/fzf/examples/key-bindings.zsh
# /usr/share/fish/vendor_functions.d/fzf_key_bindings.fish
cd /usr/share/doc/fzf/examples && tree
# .
# `-- plugin
#     `-- fzf.vim -> ../fzf.vim # looks like dangling link

Conclusion

Don't know why, but seems key binding files are not installed correctly.

(I thought dpkg -L means "show all related and installed files". If I'm wrong please correct it)

appendix

I came from https://github.com/junegunn/fzf/issues/1866#issuecomment-655104432 and https://github.com/junegunn/fzf/issues/1385#issuecomment-627095222.

Abobe that, README doesn't mention what to do exactly on this case: https://github.com/junegunn/fzf#using-linux-package-managers

Key bindings (CTRL-T / CTRL-R / ALT-C) and fuzzy auto-completion may not be enabled by default.

roeniss avatar May 11 '21 07:05 roeniss

That's strange, you should report the issue to the maintainers of the APT package.

junegunn avatar May 17 '21 04:05 junegunn

It's in progress now. I'll add comments if something changed.

roeniss avatar May 17 '21 06:05 roeniss

Hey, this appears to be still open, do we have an issue link for the APT package @roeniss ?

For some reason it works correctly in my Ubuntu 22.10 installation, but it fails in the Dockerized version running 22.04 (same as the error posted above for 21.04)

alkoclick avatar Nov 18 '21 20:11 alkoclick

@alkoclick I didn't contact to APT side because at the last moment I concluded that this is not a such problem.

can you try with git clone like this: https://github.com/junegunn/fzf/issues/2072#issuecomment-645862485

I guess some 'specific' machine/OS is not suited for apt install fzf, but don't have concrete grounds.

roeniss avatar Nov 18 '21 20:11 roeniss

I get a working installation of fzf (0.24-devel) as in your original post on this thread, but without the key binding files installed.

can you try with git clone like this: #2072 (comment)

I can try that, but it'll work, not sure what that would achieve?

Notably this is pretty low prio for me, because it works correctly on my main boxes, but fails to get these files in the containerized development environment that I have.

alkoclick avatar Nov 18 '21 20:11 alkoclick

Just as an fyi to anyone following this, the correlated ubuntu launchpad bug is reported at: https://bugs.launchpad.net/ubuntu/+source/fzf/+bug/1928670. In my testing, this is probably the place to report the issue as it appears to be ubuntu specific.

jaron-l avatar Oct 10 '22 14:10 jaron-l

Thank you @jaron-l. I'll close this one.

roeniss avatar Oct 11 '22 02:10 roeniss