Junegunn Choi
Junegunn Choi
> It will increase the message size for Scan object and does not bring any advantages for Scan, so for me I prefer we do not add it if possible......
Thanks, that is one option. But can we update the documentation of `Scan#setLimit` to say: > ... When used with `TableInputFormat` or `TableSnapshotInputFormat`, this limit is applied locally to each...
I understand your point. > Not all users will look deeply into the javadoc True, and unfortunately, those users will still complain that `Scan#setLimit` doesn't work as expected no matter...
I see. Actually, when I opened this PR I was considering deprecating the `row.limit.per.inputsplit` configuration, because with `Scan#setLimit`, we have a unified interface for per-split limit, eliminating the need for...
`tmux run-shell` runs the process in the background, so it won't work with interactive programs. ```sh tmux run-shell top # hangs tmux run-shell vim # fails ``` So you have...
No specific plan for now. > I think it seems to fix the issue of bash functions not being exported with `--tmux`. So with the binary built from the source,...
> Not the `run-shell` Any idea why it's still not working for you? It works fine on my system. ```sh tmux run-shell 'seq 100 | fzf --tmux bottom' ```
https://github.com/junegunn/fzf-git.sh/blob/279050e2eba5b9f4c5b057ca7dbc7e02e67315a1/fzf-git.sh#L110 We may support other services in the future. For example, see https://github.com/junegunn/fzf-git.sh/pull/72.