react-native-rename icon indicating copy to clipboard operation
react-native-rename copied to clipboard

Missing Rename in AppDelegate.mm

Open finnp opened this issue 2 years ago • 1 comments

Describe the bug It did not rename the module name in AppDelegate.mm To Reproduce

#import "AppDelegate.h"

#import <React/RCTBundleURLProvider.h>

@implementation AppDelegate

- (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(NSDictionary *)launchOptions
{
  self.moduleName = @"aiflashcards";
  // You can add your custom initial props in the dictionary below.
  // They will be passed down to the ViewController used by React Native.
  self.initialProps = @{};

  return [super application:application didFinishLaunchingWithOptions:launchOptions];
}

- (NSURL *)sourceURLForBridge:(RCTBridge *)bridge
{
#if DEBUG
  return [[RCTBundleURLProvider sharedSettings] jsBundleURLForBundleRoot:@"index"];
#else
  return [[NSBundle mainBundle] URLForResource:@"main" withExtension:@"jsbundle"];
#endif
}

@end

Screenshots Screenshot 2023-12-01 at 11 52 18

Environment (please complete the following information):

  • operating system: macOS 14.0 Beta (23A5286i)
  • npm version: 8.12.1
  • node version: v18.4.0
  • react-native-rename version: latest
  • react-native version: 0.72.7

finnp avatar Dec 01 '23 10:12 finnp

The issue appears to be that you use the display name from iOS (CFBundleDisplayName) as current name. Which I don't think commonly would be used as a module name here?

Generally I am missing that distinction in your project.

finnp avatar Dec 01 '23 10:12 finnp