react-native-rename icon indicating copy to clipboard operation
react-native-rename copied to clipboard

Changes deep link configurations in iOS

Open nephix opened this issue 4 years ago • 0 comments

When running react-native-rename Test App -b org.testapp it seems to correctly change the content of the file:

packages/mobile/ios/project/Info.plist

before:

	<key>CFBundleDisplayName</key>
	<string>project</string>

after:

	<key>CFBundleDisplayName</key>
	<string>Test App</string>

But, it also changes settings in the CFBundleURLTypes section which is used for deep linking:

before:

	<key>CFBundleURLTypes</key>
	<array>
		<dict>
			<key>CFBundleTypeRole</key>
			<string>Editor</string>
			<key>CFBundleURLName</key>
			<string>project</string>
			<key>CFBundleURLSchemes</key>
			<array>
				<string>project</string>
			</array>
		</dict>
	</array>

after:

	<key>CFBundleURLTypes</key>
	<array>
		<dict>
			<key>CFBundleTypeRole</key>
			<string>Editor</string>
			<key>CFBundleURLName</key>
			<string>Test App</string>
			<key>CFBundleURLSchemes</key>
			<array>
				<string>Test App</string>
			</array>
		</dict>
	</array>

but Test App isn't a valid URL scheme for deep links

Expected

It should only change the CFBundleDisplayName property

nephix avatar May 01 '21 15:05 nephix